[EventCalendar] navigation links

Alex Tingle alex at firetree.net
Sun Jan 25 13:03:53 UTC 2009


Hi Jeff,

On 25 Jan 2009, at 03:54, Jeff Dodson wrote:

> Alex, I noticed on Lia's calendar (http://aksb.org/calendar/), her  
> links
> were at the top and that she was not experiencing the same problem  
> with the
> wrong label for the previous month, so I changed mine to the top  
> also and
> the issue corrected (another was created, see below).

Brilliant! I'm kicking myself for not noticing that. Thank you. Sadly  
I *still* can't reproduce the problem, but it does suggest what might  
be going wrong on your set-up. Try this replacement copy of calendar- 
basic.php (attached) and let me know how you get on.

The change is quite simple, so you might prefer to make it by hand:

Index: calendar-basic.php
===================================================================
--- calendar-basic.php	(revision 88877)
+++ calendar-basic.php	(working copy)
@@ -276,7 +276,7 @@
    function generate()
    {
      $result='';
-    $curr_dateobj = $this->begin_dateobj;
+    $curr_dateobj = clone($this->begin_dateobj);
      while($curr_dateobj->less_than($this->limit_dateobj))
      {
        $days_in_month =$curr_dateobj->days_in_month();


>  Perhaps this will
> help you birddog this one.  I am happy to provide you with ssh  
> access to my
> dev site, it is experiencing the same issue.  Tell me what you need  
> and a
> secure means to deliver it to you.  Just curious, I use firebug and  
> change
> and test code using my firefox browser before implementing, this  
> does not do
> what you need? (in any case, if you need ssh, just let me know).

First try the new calendar-basic.php. If that doesn't work then set up  
the ssh access. FTP would be just as good - I need to be able to  
change the plug-in's code on the server.


> On the down side, putting the nav links to the top causes the  
> following code
> to display below my big calendar:
>
> :day_length 
> =9&hide_logo=1&navigation=1&num_months=1&show_only_events=1]

Thanks for another good bug report. Those & characters can come out as  
& or & or &... I've fixed it so that EC now copes with all(?)  
possibilities. See the latest dev code.


>>> Also, if I click on the "January 2009" link at the top when I first
>>> browse
>>> there, I get this 404 error: __404 Error: Not Found!__
>>
>> Hmm, yes that's a bug, but more with Wordpress than EC. The JS
>> generates a URL that looks like this:
>>   http://www.example.com/?m=200901&ec3_listing=events  => blank
>>
>> The PHP tries to be more clever and generates...
>>   http://www.example.com/2009/01/?ec3_listing=events  => 404
>>
>> But the same thing happens with plain Wordpress, try it with a month
>> that's known to be empty...
>>   http://www.example.com/?m=201201  => blank
>>   http://www.example.com/2012/01/  => 404
>>
>> Those two URLs should be equivalent, but Wp is treating them
>> differently.
>>
>
> So weird that blank calendars everywhere else go to blank pages, its  
> just
> the month you browse to if it is blank.
>
> Because this issue exists and seems there is no solution yet, can EC  
> not
> link to blank pages?  If the month has no events, then don't make  
> the month
> title a link.  Possible?

That's quite a good idea. I think it should be reasonable easy. Thanks  
for the suggestion.

-Alex

-------------- next part --------------
A non-text attachment was scrubbed...
Name: calendar-basic.php
Type: text/php
Size: 8538 bytes
Desc: not available
Url : http://penguin.firetree.net/pipermail/eventcalendar/attachments/20090125/20db3bf8/calendar-basic.bin


More information about the EventCalendar mailing list