[EventCalendar] [Patch 4] - Fixed patch attached (Error in last patch)

[Matthew Middleton]

I mixed a comma join with an explicit join in my
latest patch, and it caused different results on
different mysql versions.  Thus, I didn't catch it
until I got an error with the latest version of mysql.
 My modification of the SQL code for the last patch
was a bit sloppy, so I rewrote it to be much simpler. 
Instead of having different SQL queries when category
filtering is enabled, the existing queries are simply
modified.

I have attached a cleaned-up patch that makes my
modifications to the sql syntax much more readable,
fixes the query error that some mysql versions
produce, and fixes the javascript error that Chris
found.  (This patch, like the rest, is applied to the
latest head revision)

To make the same query work in all cases, I changed
the comma join in ec3_util_calendar_days() to an
explicit INNER JOIN.  I also removed the "AND post.id
= id" statement in favor of an ON condition on the
join statement.

I have a testing site up at H. T. T. P. S. colon slash
slash matthewmiddleton (dot) com slash wptest.  The
username is test and the password is testing.

I am still working on the javascript changes to make
multiple calendars work, so this fix is not in this
patch.  I am also working on another plugin,
tentatively called "ec3 everywhere", to enable tags
(such as [show_calendar]) in ordinary pages and posts.
 My goal for that plugin is to include every possible
feature that anyone might want to do with events.  For
example, I might implement event registration to allow
people to sign up for your events.  If anyone has any
"wish lists", please let me know.

-Matthew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch4.diff
Type: application/octet-stream
Size: 28342 bytes
Desc: 36696702-patch4.diff
Url : http://penguin.firetree.net/pipermail/eventcalendar/attachments/20071016/5dd7af47/patch4-0001.obj