[EventCalendar] Escaping commas

[Alex Tingle]

Hi Marc,

Thanks for the patch. Could you please have a look at the head branch.
There are changes in this area that you've obviously not seen.

vCalendar and iCalendar are the same thing. The name changed when they
went to version 2. So I don't like your idea of having two separate
functions. We should have one function, and it should get it right.

Here are the differences you are suggesting:

- Change MIME type from text/x-vCalendar to text/calendar
  I agree with this change. It agrees with the spec:
  http://www.ietf.org/rfc/rfc2445.txt [3.1]

- Change the file name from XXX.ical to XXX.ics
  I agree with this too, it's also in the spec. [3.10]

- Change the calname from the filename to the blogname.
  OK. But you've not escaped it.

- Escape characters \,; in summary & description.
  OK.

- Use post_content as description if there is no excerpt.
  Eiuw! I'm not sure about that. Using the content gives you all sorts
  of HTML cleanup problems. I'm not sure that the WHOLE posts is
  appropriate for the calendar description.
  Perhaps we could use a WP function like get_the_excerpt(), which should 
  do the right thing?

- Follow MS Outlook convention to make non-all-day events be opaque
  by default.
  This ventures into busy-time tracking territory. I'm not sure we want
  to go there, but there's no harm I suppose.

I'd really like to see another patch that incorporates these comments.

regards,

-Alex

--

On Wed, 13 Sep 2006 21:46:54 +0200
"Marc Schumann" <wurblzap at gmail.com> wrote:

> Alex,
> 
> 2006/9/13, Alex Tingle <alex at firetree.net>:
> > Could you post your change as a patch (unified diff). Either here on
> > the list, or in the patches section on Sourceforge:
> 
> I put a patch up on Sourceforge for this
> (https://sourceforge.net/tracker/index.php?func=detail&aid=1558147&group_id=176316&atid=876754).
> 
>    Regards
>       Marc
> 
> _______________________________________________
> EventCalendar mailing list
> EventCalendar at firetree.net
> http://penguin.firetree.net/cgi-bin/mailman/listinfo/eventcalendar


-- 
:: Let me solve your problems: http://www.firetree.net/consulting/
:: alex.tingle AT firetree.net  +44-7901-552763